Re: [Libguestfs] [PATCH 1/2] lib: Allow the COMPILE_REGEXP macro to be used everywhere.
On Tuesday 23 February 2016 09:17:42 Richard W.M. Jones wrote:
Since the daemon links to pcre and use regular expressions, and
since
the COMPILE_REGEXP macro doesn't depend on any aspects of the
library-side code (eg. the guestfs_h handle etc), we can allow the
daemon to use the COMPILE_REGEXP macro. Move the macro to
"guestfs-internal-all.h" to permit this.
---
LGTM -- would you please move the <pcre.h> include from
guestfs-internal.h to guestfs-internal-all.h as well?
Thanks,
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)