Re: [Libguestfs] [PATCH 1/3] macosx: Includes/defines for byteswap operations
On 12 February 2015 at 18:28, Pino Toscano <ptoscano(a)redhat.com> wrote:
[much byteswapping]
This code clearly need some refactoring, before adding more
copy/pasted
parts to it. I'd say to do this in two steps:
a) moving the definitions of the current be32toh/etc to a new
src/guestfs-byteswap.h (internal), making use of it
b) add the proper definitions needed on Mac OS X
Heh. Yet again, I should have gone with the first hunch, but
refactoring existing code seemed, um, preposterous for a newbie.
Thanks for the suggestion.
Is it generally preferred to post updated versions of the same patch
(or rather new approaches to patching the same code) with an
In-Reply-To: to previous patch, or in a new thread?
--
M.