Re: [Libguestfs] [libnbd PATCH v2 3/5] api: Add nbd_set_strict_mode
On Fri, Sep 11, 2020 at 04:49:54PM -0500, Eric Blake wrote:
@@ -451,7 +464,7 @@ test whether this is the case with
L<nbd_supports_tls(3)>.";
"get_tls", {
default_call with
- args = []; ret = REnum (tls_enum);
+ args = []; ret = REnum tls_enum;
may_set_error = false;
shortdesc = "get the TLS request setting";
longdesc = "\
@@ -692,7 +705,7 @@ blindly setting a constant value.";
"get_handshake_flags", {
default_call with
- args = []; ret = RFlags (handshake_flags);
+ args = []; ret = RFlags handshake_flags;
may_set_error = false;
shortdesc = "see which handshake flags are supported";
longdesc = "\
You might want to put these two hunks in a separate commit since I
believe it's a clean up and so could be a candidate for cherry-picking
to the stable branch.
- - -
I looked over the rest of this patch and it all looks sensible and a
nice new feature, so ACK.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org