Re: [Libguestfs] [PATCH REBASED] Remove main loop
On Mon, Sep 14, 2009 at 12:44:15PM +0100, Matthew Booth wrote:
On 14/09/09 12:10, Richard W.M. Jones wrote:
> This is the only patch I currently have outstanding. No changes from
> the previous posting, except I rebased it against the head of git.
I'm still reviewing this (and probably will be for a while). I have a
high-level observation at this stage, though. Several error paths in
this code (and the previous code, too) would be a whole lot simpler if
LAUNCH and CANCEL were turned into real protocol messages, and receive
file was terminated with ACK. This would also simplify review.
We can't change the protocol because it's baked into other appliances
that we've shipped and people could use the wrong appliance and
library version combination. (At the moment this does work).
Rich.
--
Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines. Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v