Re: [Libguestfs] [PATCH 1/3] mllib: add checking for btrfs subvolume

On Thursday 07 July 2016 16:54:20 Richard W.M. Jones wrote: > How about this, which is type safe and a lot simpler: > > let is_btrfs_subvolume g fs = > let device = g#mountable_device fs in > try > ignore (g#mountable_subvolume fs); true > with Guestfs.Error msg as exn -> > if g#last_errno () = Guestfs.Errno.errno_EINVAL then false > else raise exn This is what I was writing too, but you were faster :) I think this will fail to build as "device" is unused, so the first line should be: (* Make sure we can determine the device of the mountable. *) ignore (g#mountable_device fs);