Re: [Libguestfs] [PATCH 3/7] customize: add support for pvvxsvc
On Tue, 2016-04-05 at 13:11 +0100, Richard W.M. Jones wrote:
On Tue, Apr 05, 2016 at 01:47:29PM +0200, Cédric Bosdonnat wrote:
> The output of the first boot scripts is available in the guest as
> -F<C:\Program Files\Red Hat\Firstboot\log.txt>.
> +F<C:\Program Files\Guestfs\Firstboot\log.txt>.
Changing this path is fine, but let's split it into a separate patch.
Ok, I'll split that one.
> + let services = ["rhsrvany.exe";
"pvvxsvc.exe"] in
> + let srvany = (
> + try
> + List.find (
> + fun service -> (
> + try
> + let chan = open_in (virt_tools_data_dir // service)
> in
> + close_in chan;
> + true
> + with _ ->
> + false
> + )
> + ) services
> + with Not_found ->
> + error (f_"One of rhsrvany.exe or pvvxsvc.exe is missing in
> %s. One of them is required in order to install Windows firstboot
> scripts. You can get one by building rhsrvany (
> https://github.com/rwmjones/rhsrvany)")
> + virt_tools_data_dir
> + ) in (
There's a stray ( here, and lots of code gets reindented
for reasons I don't understand but may be connected to that
stray (.
Oh, I think that's an ocaml-beginner problem of mine ;) I'll fix it.
--
Cedric
> + g#hivex_commit None;
> + g#hivex_close ();
> +
> + firstboot_dir
> + )
End of the stray ) and reformatting.
Rich.