Re: [Libguestfs] [PATCH 3/4] ocaml: Use automake to build the C part of the bindings.

Richard W.M. Jones wrote: ... Nice clean-up/simplification. Personally I'd find it easier to read/review if you split the two new lines that are longer than 80 columns. $(OCAMLMKLIB) -o mlguestfs \ libguestfsocaml_a-guestfs_c_actions.o \ libguestfsocaml_a-guestfs_c.o \ guestfs.cmo -L$(top_builddir)/src/.libs -lguestfs That also helps to see the common "libguestfsocaml_a-" prefix, which if there were 3 or more I'd suggest to factor it out and use GNU make's $(addprefix ...), assuming you already depend on GNU make. But, seeing the $< in other lines, maybe you do already. But see below... Oh. Actually, seeing this pair of long-named .o files again, and knowing that they are the components of an automake library, I realized that there should be an automake-provided variable for the pair of them, poked the generated Makefile and found this: am_libguestfsocaml_a_OBJECTS = \ libguestfsocaml_a-guestfs_c.$(OBJEXT) \ libguestfsocaml_a-guestfs_c_actions.$(OBJEXT) So you can simplify further by using $(am_libguestfsocaml_a_OBJECTS) in both of those rules.