Re: [Libguestfs] [PATCH v2 1/2] daemon: Reimplement statvfs API in OCaml.
On Tuesday, 3 October 2017 14:24:13 CEST Richard W.M. Jones wrote:
common/mlutils: Unix_utils.StatVFS.statvfs: This commit implements a
full-featured binding for the statvfs(3) function.
We then use this to reimplement the daemon statvfs API in OCaml.
Note that the Gnulib fallback is fixed in this commit. It previously
referenced non-existent field names in the fs_usage struct.
TBH I'd just drop the gnulib fallback (i.e. the fsusage module):
- (f)statvfs is POSIX since 2001
- Linux, macOS, and *BSDs have been supporting it already for years
(decades, even)
- Windows (even if untested for long) has the fallback code already
This way there's less dead code around, and one gnulib module less.
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)