[Libguestfs] Re: [PATCH nbdkit 4/4] tests: Add a regression test for DOS line endings in shebang plugins

On Thu, Apr 18, 2024 at 03:32:33PM -0500, Eric Blake wrote: > On Thu, Apr 18, 2024 at 08:38:02PM +0100, Richard W.M. Jones wrote: > > --- > > tests/Makefile.am | 3 ++ > > tests/test-shebang-crlf.sh | 59 ++++++++++++++++++++++++++++++++++++++ > > tests/shebang-crlf.py | 2 ++ > > 3 files changed, 64 insertions(+) > > > > > --- /dev/null > > +++ b/tests/shebang-crlf.py > > @@ -0,0 +1,2 @@ > > +#!../nbdkit python > > +# See also: test-shebang-crlf.sh > > -- > > Is checking in a bare CR to git going to cause problems to someone who > checks out the repository on a platform where they choose to have git > do CR munging? This seems like the sort of plugin where we are better > off generating it on the fly rather than relying on the file surviving > the user's environment. Yes I think that's a better idea. I'll respin this (probably not this week) with the suggested change.

> Otherwise, this series looks fine. > > -- > Eric Blake, Principal Software Engineer Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW _______________________________________________ Libguestfs mailing list -- guestfs(a)lists.libguestfs.org To unsubscribe send an email to guestfs-leave(a)lists.libguestfs.org