Re: [Libguestfs] [PATCH v6 3/3] v2v: ova: don't extract files from OVA if it's not needed
Hi,
I've addressed all the comments. Just one note below...
On Tue, 31 Jan 2017 12:12:06 +0000
"Richard W.M. Jones" <rjones(a)redhat.com> wrote:
On Mon, Jan 30, 2017 at 10:43:16PM +0100, Tomáš Golembiovský wrote:
> -formats="tar zip tar-gz tar-xz"
> +formats="zip tar-gz tar-xz"
>
> if [ -n "$SKIP_TEST_V2V_I_OVA_FORMATS_SH" ]; then
> echo "$0: test skipped because environment variable is set"
> @@ -63,9 +63,6 @@ cp ../test-v2v-i-ova-formats.ovf .
>
> for format in $formats; do
> case "$format" in
> - tar)
> - tar -cf test-$format.ova test-v2v-i-ova-formats.ovf disk1.vmdk
disk1.mf
> - ;;
Is dropping this test necessary?
The test has been moved into a separate script test-v2v-i-ova-tar.sh.
It's because the new test has two .expected files.
Tomas
--
Tomáš Golembiovský <tgolembi(a)redhat.com>