Re: [Libguestfs] [PATCH 0/4] Provide better fake virtio-* test data for virt-v2v.
On Thursday 05 November 2015 16:10:05 Richard W.M. Jones wrote:
Patch 1 moves the v2v/fake-virtio-win and v2v/fake-virt-tools
directories to the recently created test-data/ hierarchy. This is
just refactoring with no functional change at all.
Ah, you did beat me to it :)
As additional step, could we move to run(.in) the exports of
VIRT_TOOLS_DATA_DIR and VIRTIO_WIN? In case you need custom ones, you
can always run: ./run env VIRT_TOOLS_DATA_DIR=.. virt-v2v ..
Patches 2-4 then extend the available (fake) virtio-win drivers:
- Patch 2 adds all of the drivers from the virtio-win RPM.
- Patch 3 adds all of the drivers from the virtio-win ISO (which are
different from the virtio-win RPM, for various reasons that don't
make sense).
- Patch 4 adds bits of the *.inf files, which will allow us to do
proper driver discovery in future. See Vadim's posting here:
https://www.redhat.com/archives/libguestfs/2015-October/msg00352.html
LGTM.
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)