On Thu, Mar 31, 2022 at 03:38:40PM +0200, Laszlo Ersek wrote:
Thanks! BTW: do you have any comments about the following serial log
message (see the cover letter):
[
https://listman.redhat.com/archives/libguestfs/2022-March/028498.html]
> nbdkit: file[1]: error: reading initial client flags:
conn->recv:
> Connection reset by peer
What's happening is nbdkit is sending the initial handshake and
expecting client flags back, but received a RST instead. I couldn't
quite work out exactly why, but it seems to be a side-effect of the
way we test that the NBD server is up:
https://github.com/libguestfs/virt-p2v/blob/c1a4bd83a8bba5959470ef1f6deb0...
I believe after your simplifications that code is not necessary at
all, since with systemd socket activation the sockets passed to the
server are always listening (even if the server isn't ready to accept
a connection at that moment).
Does it work OK if you simply remove wait_for_nbd_server_to_start and
the place where that function is called?
(CC-d Eric)
Rich.
--
Richard Jones, Virtualization Group, Red Hat
http://people.redhat.com/~rjones
Read my programming and virtualization blog:
http://rwmj.wordpress.com
nbdkit - Flexible, fast NBD server with plugins
https://gitlab.com/nbdkit/nbdkit