Re: [Libguestfs] daemon/ warnings
On Mon, Aug 10, 2009 at 10:26:03AM +0100, Matthew Booth wrote:
On 10/08/09 10:21, Jim Meyering wrote:
>Matthew Booth wrote:
>>On 10/08/09 09:57, Jim Meyering wrote:
>>>Here are a few warning-removal changes for daemon/:
>...
>>What warnings are you turning on? I normally compile with -Wall, and I
>>don't get warning for unused function arguments:
>
>I started with these: -Wall -W -Wextra
Now I see where you're coming from. ACK.
Do you find it's generally useful to turn these on across the board? In
my experience, until you get down to zero compiler warnings and turn on
-Werror, they often go unnoticed. Are we likely to be able to get down
to zero compiler warnings?
I don't see why not - libvirt managed to get there, even for the crazy
mingw32 compile. Once there, development should definitely be done using
-Werror on at all times. Also using the new
AM_SILENT_RULES([yes])
lets you quite clearly see compile warning even without -Werror
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|