On Wed, Aug 12, 2009 at 02:45:02PM +0200, Jim Meyering wrote:
Using the latest code, I was seeing a failure of the remote alloc
part
of the test-remote.sh test:
The fix is to ensure that we close the file handle *after*,
not before calling xdr_destroy.
fprintf (stderr, _("guestfish: protocol error: could not send initial greeting
to server\n"));
- fclose (fp);
xdr_destroy (&xdr);
+ fclose (fp);
return -1;
Ouch, that's a very subtle and non-obvious bug. Definite ACK.
I wonder where else we have bugs like that ...
Rich.
--
Richard Jones, Emerging Technologies, Red Hat
http://et.redhat.com/~rjones
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top