Re: [Libguestfs] [PATCH v2 1/2] v2v: bootloaders: Handle no Bootloader::Tools default section (RHBZ#1472208).
On Tuesday, 18 July 2017 19:59:20 CEST Richard W.M. Jones wrote:
In SUSE guests, handle the case where
Bootloader::Tools::GetDefaultSection () returns undef.
Previously this would return an empty string and cause a bogus error
in subsequent code:
virt-v2v: error: libguestfs error: statns: statns_stub: path must start
with a / character
---
I saw this was pushed, even though v1 was NACKed by me, and there was
no further information on actual guests (i.e. real world, not the one
that comes out of the virt-builder templates) affected by this.
The pushed patch is basically dead code, and I don't see why the urge
to have it regardless.
Furthermore, I don't see the logic in have me re-NACK every new version
of a patch series that I NACKed, while the new series is merely a
repost of the old one, or in general the reasons of the NACK did not
change at all.
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)