[Libguestfs] Re: [PATCH] WIP: convert: Use yum/apt/... for package removals, not rpm/dpkg

On 2/4/25 3:08 AM, Richard W.M. Jones wrote: > On Mon, Feb 03, 2025 at 02:35:20PM -0500, Cole Robinson wrote: >> + | Guest_packages.Unknown_package_manager msg >> + | Guest_packages.Unimplemented_package_manager msg -> >> + error "%s" msg > > These exceptions can be thrown by Guest_packages.uninstall_command > below, so you'll need to catch them. But I think this function > (guest_pkgs_command) effectively disappears so the try/with clause > moves into the next function: > >> + in >> + >> + let uninstall_packages pkgs = >> + let cmd = guest_pkgs_command(Guest_packages.uninstall_command pkgs) in > > guest_pkgs_command goes away, but instead you need to catch the two > exceptions that Guest_packages.uninstall_command can throw here. Thanks, these mails were very helpful and informative. One question here, do all distinct errors need to be handled explicitly? Or is there something like python try: foo() except Exception as err: