Re: [Libguestfs] [v2v PATCH 9/9] convert_linux: set "gcaps_default_cpu = false" for x86_64 RHEL-9.0+ guests
On 04/20/22 18:54, Richard W.M. Jones wrote:
For patches 4-9 (and so the whole series):
Reviewed-by: Richard W.M. Jones <rjones(a)redhat.com>
Series merged as commit range e7539dc6f6d1..f28757c6d100, with the
following difference on patch#1:
1: 70898075fb25 ! 1: a50b975024ac types: introduce the "gcaps_default_cpu"
field
@@ -18,6 +18,9 @@
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2076013
Signed-off-by: Laszlo Ersek <lersek(a)redhat.com>
+ Message-Id: <20220420162333.24069-2-lersek(a)redhat.com>
+ [lersek(a)redhat.com: mention "-cpu qemu64" near the new field def
(Rich)]
+ Reviewed-by: Richard W.M. Jones <rjones(a)redhat.com>
diff --git a/lib/types.mli b/lib/types.mli
--- a/lib/types.mli
@@ -28,7 +31,8 @@
protocol level. *)
+
+ gcaps_default_cpu : bool;
-+ (** True iff the guest OS is capable of running on QEMU's default VCPU model.
++ (** True iff the guest OS is capable of running on QEMU's default VCPU model
++ (eg. "-cpu qemu64" with the Q35 and I440FX machine types).
+
+ This capability only matters for the QEMU and libvirt output modules,
+ where, in case the capability is false *and* the source hypervisor does
Thanks!
Laszlo