Re: [Libguestfs] [PATCH 2/2] Introduce a --key option in tools that accept keys
On Thursday, 20 September 2018 12:15:12 CEST Richard W.M. Jones wrote:
This would have been a bit easier to review if the keystore
changes had been broken out from the tools changes.
I actually thought (even too much) about various ways of splitting it;
since I wanted to not become a new Buridan's ass [1], then I lumped it
all in a single patch.
Splitting is not an issue, so if you suggest a preferred layout I can
work on it.
[1] https://en.wikipedia.org/wiki/Buridan%27s_ass
I think Eric's / qemu's shared key stuff sounds very complex,
and I
wonder who uses it. But in any case what you've proposed is
extensible enough that we would be able to add other methods to pass
the key in future.
As I suggested in my reply to Eric's email, we can always create a "fd"
selector, if needed.
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)