Re: [Libguestfs] regression: file does not understand the -S option

On 9/20/23 23:42, Olaf Hering wrote: This is likely from commit 23986d3c4f4d ("file: Use -S option with -z", 2022-11-28). Does your error output contain file: invalid option -- 'S' ? If it does, then I think we could modify "daemon/file.ml" and "daemon/filearch.ml". Try "file" with the current options, and if there's a failure, and stderr contains the above string, retry without -S. Unfortunately, this is a bit messy. We'd probably want to cache the availability of -S. Also, because this logic is used from multiple places, we'd first have to factor out the current "file" invocation -- minimally, try to rebase the "file" invocation in "daemon/filearch.ml" to the interface exposed by "daemon/file.mli". Laszlo