Re: [Libguestfs] [PATCH nbdkit 2/2] common/include/checked-overflow.h: Provide fallback

On Mon, Nov 15, 2021 at 02:11:01PM +0100, Laszlo Ersek wrote: If I sound schizophrenic on RHEL 7 that'll be because I'm in two minds still about supporting it. In this particular case I was trying to test the OCaml changes on the oldest version of OCaml I have easy access to and found that there were various problems compiling on RHEL 7. I fixed the other problems, but this fix was a bit more controversial. This doesn't sound very convenient, but there's a stronger reason to keep stuff working with GCC 3/4 and that's because OpenBSD sticks with GCC 4.2 as it was the last GPLv2+ version. I think the reason OpenBSD does this is wrong, but that's their choice. (Of course they have Clang). I agree. If you want to have a go at standard C versions that would be great. Even unsigned addition looks very hard. I found this lengthy paper on the subject: https://www.cs.utah.edu/~regehr/papers/overflow12.pdf Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW