Re: [Libguestfs] [libnbd PATCH v2 4/5] states: Allow in-flight read while writing next command
On 5/22/19 4:24 AM, Richard W.M. Jones wrote:
Did we think it was better that the READY state should check if
there
are commands to issue and automatically transition to
PREPARE_FOR_WRITE if so?
Yes. In v1, I modified states-reply.c to do the check for cmds_to_issue
and bypass %.READY; but in v2, states-reply.c is untouched, and states.c
does the check for cmds_to_issue directly within %READY. (Actually,
that's fallout from patch 2 turning READY into a full command queue,
rather than a depth 1 queue).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 488 bytes)