Re: [Libguestfs] [PATCH v2] daemon: proto: Make the guestfsd main loop messages consistent and useful.
On Thursday, 12 October 2017 16:30:09 CEST Richard W.M. Jones wrote:
After this change the debugging output looks like this:
guestfsd: enter: mount (0x1) request length 64 bytes
commandrvf: stdout=n stderr=y flags=0x0
commandrvf: udevadm --debug settle -E /dev/sda1
calling: settle
command: mount '/dev/sda1' '/sysroot//'
[ 0.951731] EXT4-fs (sda1): mounting ext2 file system using the ext4 subsystem
[ 0.954585] EXT4-fs (sda1): mounted filesystem without journal. Opts: (null)
guestfsd: leave: mount (0x1) took 0.01 secs
guestfsd: enter: touch (0x3) request length 52 bytes
guestfsd: leave: touch (0x3) took 0.00 secs
---
LGTM.
Maybe a small visual improvements could be replacing the "enter" and
"leave" texts with ASCII arrows, e.g. "<="/"<-" and
"=>"/"->":
guestfsd: [->] touch (0x3) request length 52 bytes
guestfsd: [<-] touch (0x3) took 0.00 secs
This may make the output slightly more eye-friendly, but YMMV.
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)