Re: [Libguestfs] [libnbd RFC PATCH] First stab at CI infrastructure
On Thu, Apr 08, 2021 at 05:19:18PM +0200, Martin Kletzander wrote:
Sure, I removed MacOS, we can add it later if you want. Another
option
is to make the MacOS and MinGW builds not required to pass. In that
case they would run, you could see the output, but if they failed, then
that would not fail the whole pipeline.
That sounds good.
I think we have a good chance of making it work on MacOS with minimal
effort. MinGW is probably going to be harder because sockets work
completely differently. (nbdkit port to Windows was easier because we
don't expose the sockets through the nbdkit API.)
>>Example:
>>
>> https://gitlab.com/nertpinx/libnbd/-/jobs/1140619387
>>
>>GCC does not find this even with --enable-gcc-warnings (already used).
>
>I'm not sure to what extent we want to use --enable-gcc-warnings on
>the non-Linux platforms. What does libvirt do here? Do they aim to
>have GCC warnings clean even on non-Linux?
>
Everywhere except some distributions that have literal bugs in them
(faulty dependent packages and so on).
Hmm tricky. I have always compiled on Linux with this flag myself.
But when I checked on *BSD I did not bother (since they often use
weird / out of date versions of GCC), and just ran the tests. In fact
even the full tests don't always pass on *BSD.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org