Re: [Libguestfs] [PATCH 0/2] added filesystem_walk0 low level API

Hi, while reviewing the new series of tsk-related changes, I'm noticing common mistakes in all of them: I'll list them below, not copy/paste-ing them every review. (a) please check the coding style, in particular - the lack of space between a function name and its following opening parenthesis; e.g. do_something(param) -> do_something (param) - the style of functions, e.g.: | int do_something (...) needs to be | int | do_something (...) - style of function prototypes (everything in a single line) (b) please avoid if statements with side effects, as it makes code reading and refactoring harder (c) please put explanations and message in the messages of the actual commits, instead of in the cover letters sent to the mailing list: otherwise, browsing the git history in the future will not give many clues about the newly added APIs (d) please wrap descriptions for actions at 80 columns max. Thanks, -- Pino Toscano