Re: [Libguestfs] [PATCH] v2v: virtio-win: include *.dll too
On Mon, Oct 26, 2015 at 09:00:03PM +0300, Roman Kagan wrote:
Windows QXL drivers include also qxldd.dll which used to get
filtered
out and not copied over into the guest. As a result QXL driver failed
to install due to a missing file.
(* Skip files without specific extensions. *)
- let extensions = ["cat"; "inf"; "pdb";
"sys"] in
+ let extensions = ["cat"; "dll"; "inf";
"pdb"; "sys"] in
Actually no, this part is (may be) wrong.
This causes WdfCoInstaller*.dll from the ISO to be copied in. It's
not clear to me whether these files are needed - I suspect not.
It also causes the tests to fail, although only when you have
installed the optional ocaml oUnit2 package:
----------------------------------------------------------------------
Error: virt-v2v:3:Utils.virtio_iso_path_matches_guest_os.
File
"/home/rjones/d/libguestfs/v2v/oUnit-virt-v2v-choo.home.annexia.org#01.log",
line 8, characters 1-1:
Error: virt-v2v:3:Utils.virtio_iso_path_matches_guest_os (in the log).
Raised at file "src/oUnitAssert.ml", line 45, characters 8-27
Called from file "list.ml", line 73, characters 12-15
Called from file "list.ml", line 73, characters 12-15
Called from file "src/oUnitRunner.ml", line 46, characters 13-26
path Balloon/2k12/amd64/WdfCoInstaller01011.dll should not match win2k12_64
expected: false but got: true
----------------------------------------------------------------------
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html