On Mon, Nov 04, 2019 at 09:31:09PM +0000, Richard W.M. Jones wrote:
v1 was here:
https://www.redhat.com/archives/libguestfs/2019-November/msg00003.html
This version depends on:
https://www.redhat.com/archives/libguestfs/2019-November/msg00004.html
and this series:
https://www.redhat.com/archives/libguestfs/2019-November/msg00009.html
The delta has been reduced slightly because of changes made possible
by cleaning up and fixing the quit path in nbdkit. It's still a
fairly ugly and invasive patch however, so suggestions sought about
how to make it better.
I forgot to add a few points:
* It still leaks memory slowly. I ran the v1 version overnight and it
leaked about 1 GB. Be good to find out eventually what is leaking.
* This patch might be further simplified if there was a configure
option to link a particular plugin into nbdkit statically, eg:
./configure --enable-static-plugin=memory
which is sort of a useful feature on its own.
* I think the --log=null patch is a reasonable feature on its own.
* We didn't find any crashes yet. However enabling ASAN finds
problems in both libnbd & nbdkit which I didn't investigate yet
(they are difficult to reproduce).
Rich.
--
Richard Jones, Virtualization Group, Red Hat
http://people.redhat.com/~rjones
Read my programming and virtualization blog:
http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine. Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/