Re: [Libguestfs] [PATCH v8 4/4] v2v: ova: don't extract files from OVA if it's not needed
On Sat, Feb 04, 2017 at 03:10:46PM +0100, Tomáš Golembiovský wrote:
We don't have to always extract all files from the OVA archive.
The OVA,
as defined in the standard, is plain tar. We can work directly over the
tar archive if we use correct 'offset' and 'size' options when defining
the backing file for QEMU. This puts much lower requirement on available
disk space.
Since the virt-v2v behaviour for OVA input now depends on QEMU version
available this affects some of the tests. Expected result of the
affected also has to depend on the QEMU used thus such tests will have
two *.expected files.
Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com>
This commit (I think) breaks virt-v2v when run with the libvirt
backend using an OVA input file. The error from v2v/test-v2v-i-ova.sh
is:
Original error from libvirt: internal error: missing parser implementation
for JSON backing volume driver 'raw' [code=1 int1=-1]
which I think is caused because libvirt doesn't understand a backing
file with the format 'json:{"driver":"raw",...}'. Full log
is
attached. This is similar but not exactly the same as this bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1134878
I have added a workaround in the test for now, but please look at
whether this can be fixed more permanently.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW
Attachments:
- test-v2v-i-ova.sh.log (text/plain — 16.3 KB)