Re: [Libguestfs] nbdkit / mingw support

>> Unfortunately some functions depend themselves on internals >> of the server: >> >> * nbdkit_nanosleep, nbdkit_export_name, nbdkit_peer_name call >> threadlocal_get_conn >> * nbdkit_set_error calls threadlocal_set_error >> * nbdkit_shutdown must set the quit global (or call a server function) > > Yeah, there's some awkward dependencies to figure out. It's obvious > the library has to export public nbdkit_* interfaces for the sake of > plugins, but can it also export one additional symbol _nbdkit_init() > for internal use? Then we can have the nbdkit binary pass whatever > additional hooks are needed for proper isolation of the public > interface (a callback pointer to get at threadlocal_get_conn, > threadlocal_set_error, the address of the quit global, ...), and > leave the symbol undocumented (plus the fact that the leading _ will > discourage plugins from trying to abuse it). Yes this is a good point. Also I suppose this interface between nbdkit <-> libnbdkit.so is *not* ABI so we can change this at will? It would mean that nbdkit & libnbdkit.so must always be shipped together, but that doesn't seem to be a problem.