Re: [Libguestfs] [PATCH] v2v: -i vmx: Allow ssh URLs to use spaces.
On Sunday, 10 December 2017 16:46:15 CET Richard W.M. Jones wrote:
In previous discussion here:
https://www.redhat.com/archives/libguestfs/2017-December/thread.html#00027
we preferred to use ssh://... URLs instead of server:/path. However
the URL approach had the problem that the user had to replace spaces
with %20 in the paths.
However since using space gives an error, we can replace spaces with
%20 safely in code, thus removing one obstacle from users.
The idea is not bad. OTOH, this would introduce an inconsistency with
the input URI, where all the "special" characters (spaces included)
must be escaped. Because of this, IMHO it is better to use the same
rules for all the URIs that libguestfs/v2v deals with, so there is less
confusion.
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)