Re: [Libguestfs] [PATCH v4 2/7] common: Bundle the libvirt-ocaml library for use by virt-v2v

So for patches 2, 6 and 7 ... I think for 2, we really need a plan, written down, about how and when we're going to remove the bundled library. It might be included as a README in the common/mllibvirt/ directory. But it needs to be clear about when it goes and how we're going to work towards that. For patch 6, I really need to either get rid of the test harness or move it out somewhere, but your change is fine. Patch 7 is fine, but depends on patch 2. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v