Re: [Libguestfs] [libnbd PATCH] golang: Optionally use gofmt on generated .go files
On Mon, Aug 07, 2023 at 04:11:15PM -0500, Eric Blake wrote:
On Fri, Aug 04, 2023 at 09:29:48AM -0500, Eric Blake wrote:
> Combine my recent work on improving the generated Go output with
> Tage's work on using a canonical formatter for Rust. If gofmt is
> available during the build, then the generated .go files will now use
> TAB indents and have proper columnar alignment; if it is not
> available, the project still compiles.
>
> Signed-off-by: Eric Blake <eblake(a)redhat.com>
> ---
>
> Followup to this earlier series:
> https://listman.redhat.com/archives/libguestfs/2023-July/032133.html
Now in as 9cb10b39, after rebasing to yet more rustfmt changes in the meantime.
This did seem to cause trouble with the CI:
https://gitlab.com/nbdkit/libnbd/-/pipelines/958658174
On FreeBSD only, the error is:
Error: Error on dynamically loaded library: ./../dllmlnbd.so:
/usr/local/lib/libgnutls.so.30: Undefined symbol "strverscmp(a)FBSD_1.7"
This makes no sense to me, could be a coincidental problem with
FreeBSD, gnutls or gnulib.
Rich.
>
> I still need to fold in the 'make check' verification of non-generated
> .go files, plus Dan's idea of enabling CI coverage...
This still remains on my todo list.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
_______________________________________________
Libguestfs mailing list
Libguestfs(a)redhat.com
https://listman.redhat.com/mailman/listinfo/libguestfs
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines. Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v