On Wed, Apr 11, 2012 at 02:27:49PM +0800, Wanlong Gao wrote:
Hi Rich,
I did with your suggestions, please help reviewing.
I got a compiling error,
-
File "sysprep_operation.mli", line 23, characters 17-19:
Error: Unbound type parameter 'a
make: *** [sysprep_operation.cmi] Error 2
make: Leaving directory `/work/git/libguestfs/sysprep'
-
It turns out that it's hard to make the types work out properly with
this method of passing the 'debug' function around. We would need to
use some feature of OCaml 3.12, which then wouldn't be compatible with
RHEL 6.
Try the attached patch instead, which is in any case much simpler.
I'm still a bit confused about the purpose of adding logging. How is
this better than using the -x option?
Rich.
--
Richard Jones, Virtualization Group, Red Hat
http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages.
http://libguestfs.org