[libguestfs-common PATCH] Add support for OCaml 5.0
by Jürgen Hötzel
Pervasives is deprecated since Ocaml 4.08 and has been
removed in OCaml 5.0.
https://github.com/ocaml/ocaml/pull/1605
---
mlstdutils/std_utils.ml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mlstdutils/std_utils.ml b/mlstdutils/std_utils.ml
index 0d2fa22..86b21a7 100644
--- a/mlstdutils/std_utils.ml
+++ b/mlstdutils/std_utils.ml
@@ -341,12 +341,12 @@ module List = struct
| x::xs, y::ys, z::zs -> (x, y, z) :: combine3 xs ys zs
| _ -> invalid_arg "combine3"
- let rec assoc_lbl ?(cmp = Pervasives.compare) ~default x = function
+ let rec assoc_lbl ?(cmp = Stdlib.compare) ~default x = function
| [] -> default
| (y, y') :: _ when cmp x y = 0 -> y'
| _ :: ys -> assoc_lbl ~cmp ~default x ys
- let uniq ?(cmp = Pervasives.compare) xs =
+ let uniq ?(cmp = Stdlib.compare) xs =
let rec loop acc = function
| [] -> acc
| [x] -> x :: acc
--
2.40.1
1 year, 7 months
[guestfs-tools PATCH 0/3] test "/dev/mapper/VG-LV" with "--key"
by Laszlo Ersek
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2168506
This small set covers the new /dev/mapper/VG-LV "--key" ID format in the
LUKS-on-LVM virt-inspector test.
Thanks,
Laszlo
Laszlo Ersek (3):
update common submodule
inspector: rename VGs and LVs in LUKS-on-LVM test
inspector: test /dev/mapper/VG-LV translation in LUKS-on-LVM test
common | 2 +-
inspector/test-virt-inspector-luks-on-lvm.sh | 22 ++++++++++----
test-data/phony-guests/make-fedora-img.pl | 30 +++++++++++---------
3 files changed, 35 insertions(+), 19 deletions(-)
base-commit: 67647b883e1373623212d6b9fae5098135fd5efe
1 year, 7 months
[libguestfs PATCH 0/3] test "/dev/mapper/VG-LV" with "--key"
by Laszlo Ersek
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2168506
This small set covers the new /dev/mapper/VG-LV "--key" ID format in the
libguestfs LUKS-on-LVM inspection test.
Thanks,
Laszlo
Laszlo Ersek (3):
update common submodule
LUKS-on-LVM inspection test: rename VGs and LVs
LUKS-on-LVM inspection test: test /dev/mapper/VG-LV translation
common | 2 +-
test-data/phony-guests/make-fedora-img.pl | 30 +++++++++--------
tests/luks/test-key-option-inspect-luks-on-lvm.sh | 34 +++++++++++++++-----
3 files changed, 44 insertions(+), 22 deletions(-)
base-commit: 692802bf96e0c76363d26d78a105fb79ada736de
1 year, 7 months
[v2v PATCH 0/2] test "/dev/mapper/VG-LV" with "--key"
by Laszlo Ersek
https://bugzilla.redhat.com/show_bug.cgi?id=2168506
This small set covers the new /dev/mapper/VG-LV "--key" ID format in the
virt-v2v LUKS-on-LVM conversion test. It depends on:
[libguestfs-common PATCH 0/2] recognize "/dev/mapper/VG-LV" with "--key"
Message-Id: <20230515174924.290409-1-lersek(a)redhat.com>
https://listman.redhat.com/archives/libguestfs/2023-May/031497.html
I intend to extend the LUKS-on-LVM inspection tests in guestfs-tools and
libguestfs similarly.
Thanks for reviewing,
Laszlo
Laszlo Ersek (2):
LUKS-on-LVM conversion test: rename VGs and LVs
LUKS-on-LVM conversion test: test /dev/mapper/VG-LV translation
test-data/phony-guests/make-fedora-img.pl | 30 +++++++++++---------
tests/test-v2v-fedora-luks-on-lvm-conversion.sh | 15 +++++++---
2 files changed, 28 insertions(+), 17 deletions(-)
1 year, 7 months
[PATCH nbdkit v2 0/6] New ones plugin and evil filter
by Richard W.M. Jones
This addresses most of the issues from the review of v1 here:
https://listman.redhat.com/archives/libguestfs/2023-May/031520.html
* The filter now only handles 1e-12 <= P <= 1/8. Probabilities
outside this range are treated as 0% or 100% respectively. The
reasons are given in the code and man page, but basically are to do
with stopping things from blowing up. The restriction is not
essential - it might be fixed in future. I also added tests for
small and large probabilities.
* I did *not* change probability parsing or the "inf/nan" etc case or
return the numerator and denominator separately. The parsing could
be changed/fixed later. The API/ABI could not be changed, but I'm
unconvinced that returning two numbers instead of one does anything
except push the problem elsewhere.
* A new commit is added to make <ispowerof2.h> log_2_bits work on 64
bit ints on all platforms. I tested this inside a 32 bit mock.
* Add more debugging, and in particular print the seed.
* Use Python to count bits instead of scary shell script.
* When comparing subsets in the tests, make sure they contain a stuck
bit.
* Use '**' for exponentiation consistently.
* Various other comments / typos / etc fixed and some improvements to
the man page.
* Retest.
Now I must get back to doing real work!
Rich.
1 year, 7 months
virt-v2v check-valgrind?
by Laszlo Ersek
Hi Rich,
do we expect "make check-valgrind" to succeed in virt-v2v at the moment
(at commit e83de8abe6c5)? I see there's a "valgrind-suppressions" file
in the project root, but "make check-valgrind" still fails for me, with
numerous errors.
I'm attaching the test suite log. (Compare "--error-exitcode=119" in
"m4/guestfs-progs.m4".)
Thanks
Laszlo
1 year, 7 months
[PATCH nbdkit 0/5] New ones plugin and evil filter
by Richard W.M. Jones
This is just a bit of silliness I was thinking about on the plane last
week.
Yes, I know nbdkit_parse_probability uses scanf and that's bad. I
still think we should fix scanf.
We might call the new filter "--filter=corruption" instead, but this
name stuck.
Rich.
1 year, 7 months
[libguestfs-common PATCH 0/2] recognize "/dev/mapper/VG-LV" with "--key"
by Laszlo Ersek
https://bugzilla.redhat.com/show_bug.cgi?id=2168506
The commit message of the second patch explains the idea.
The test suites in libguestfs, guestfs-tools and virt-v2v will have to
be extended so they cover this feature; I'm soon going to post the
virt-v2v update. I plan to cover the libguestfs and guestfs-tools test
suites later.
Thanks for reviewing,
Laszlo
Laszlo Ersek (2):
options/keys: key_store_import_key(): un-constify "key" parameter
options/keys: introduce unescape_device_mapper_lvm()
options/keys.c | 88 +++++++++++++++++++-
options/options.h | 3 +-
2 files changed, 89 insertions(+), 2 deletions(-)
1 year, 7 months
[libnbd PATCH 0/6] finish wrapping generated C code harder
by Laszlo Ersek
This is the last wave (wave 5). Line length maxima:
file before after
---------------- ------ -----
lib/states-run.c 102 98
lib/states.c 116 80
lib/states.h 123 86
The longest line in "lib/states.h" becomes:
> extern int nbd_internal_enter_STATE_NEWSTYLE_OPT_STRUCTURED_REPLY_RECV_REPLY_PAYLOAD (
> struct nbd_handle *h, bool *blocked
> );
The one in "lib/states-run.c":
> case STATE_NEWSTYLE_OPT_STRUCTURED_REPLY_RECV_REPLY_PAYLOAD:
> r = nbd_internal_enter_STATE_NEWSTYLE_OPT_STRUCTURED_REPLY_RECV_REPLY_PAYLOAD (h, &blocked);
> break;
We couldn't find a "scalable" approach for shortening these (the state
machine can be nested indefinitely deeply), so we decided to live with
them.
Thanks
Laszlo
Laszlo Ersek (6):
state_machine_generator: wrap debug() calls in nbd_internal_run()
generator/utils: add "pr_wrap_c_comment"
state_machine_generator: wrap state comments in lib/states.{h,c}
state_machine_generator: wrap nbd_internal_enter_* prototypes
state_machine_generator: wrap enter_*() calls and prototypes
state_machine_generator: rename, and break up the init. of,
"next_state"
generator/state_machine_generator.ml | 48 +++++++----
generator/utils.ml | 87 ++++++++++++++++++++
generator/utils.mli | 1 +
3 files changed, 119 insertions(+), 17 deletions(-)
base-commit: 99d18799f4079b9be073a3d1b0b9bf5beccf0dff
1 year, 7 months
