August 2022 - Libguestfs - libguestfs List Archives

virt-p2v VM testing bitrot?
by Laszlo Ersek 25 Aug '22

25 Aug '22

I've started looking into RHBZ 1590721 for virt-p2v. For p2v development, quick local testing is helpful. "make run-virt-p2v-directly" seems to be working great; however, the VM-based test methods seem to have developed problems, since I last looked. Namely: - "make run-virt-p2v-in-a-vm" boots quickly, but the GUI does not come up. - "make run-virt-p2v-in-an-nvme-vm" boots *incredibly slowly*. I checked, and the host CPU utilization during guest boot was around 20% (and KVM was enabled). I don't understand how or why, but exposing the "physical machine" disk over NVMe slows guest boot to a crawl -- it looks strangely "IO-bound". I don't recall this from the time I added this Makefile target! Do these symptoms look familiar? (For RHBZ 1590721, I think run-virt-p2v-directly will suffice; just wanted to record the above somewhere.) Thanks Laszlo

2 6

libnbd | Failed pipeline for master | 27a9bb45
by GitLab 25 Aug '22

25 Aug '22

Pipeline #622616934 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 27a9bb45 ( https://gitlab.com/nbdkit/libnbd/-/commit/27a9bb45c70dbb1112cab6bdc1a61b21f… ) Commit Message: common/include: Add a function to compute log2(... Commit Author: Richard W_M_ Jones ( https://gitlab.com/rwmjones ) Pipeline #622616934 ( https://gitlab.com/nbdkit/libnbd/-/pipelines/622616934 ) triggered by Richard W_M_ Jones ( https://gitlab.com/rwmjones ) had 2 failed jobs. Job #2932821050 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2932821050/raw ) Stage: builds Name: x86_64-freebsd-12 Job #2932821041 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2932821041/raw ) Stage: builds Name: x86_64-opensuse-leap-153 -- You're receiving this email because of your account on gitlab.com.

1 0

libnbd | Failed pipeline for master | 1ea26554
by GitLab 24 Aug '22

24 Aug '22

Pipeline #621810878 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 1ea26554 ( https://gitlab.com/nbdkit/libnbd/-/commit/1ea26554ae9ef31eb9775bf662b763523… ) Commit Message: api: Fix opt_mode assertion failure with SR dis... Commit Author: Eric Blake ( https://gitlab.com/ebblake ) Pipeline #621810878 ( https://gitlab.com/nbdkit/libnbd/-/pipelines/621810878 ) triggered by Eric Blake ( https://gitlab.com/ebblake ) had 2 failed jobs. Job #2928371510 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2928371510/raw ) Stage: builds Name: x86_64-freebsd-12 Job #2928371478 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2928371478/raw ) Stage: builds Name: x86_64-opensuse-leap-153 -- You're receiving this email because of your account on gitlab.com.

1 0

libnbd | Failed pipeline for master | 9e5bf05a
by GitLab 24 Aug '22

24 Aug '22

Pipeline #621127458 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 9e5bf05a ( https://gitlab.com/nbdkit/libnbd/-/commit/9e5bf05a219668194265e2e450a032127… ) Commit Message: tests: Fix nbdkit sh script error The test log... Commit Author: Eric Blake ( https://gitlab.com/ebblake ) Pipeline #621127458 ( https://gitlab.com/nbdkit/libnbd/-/pipelines/621127458 ) triggered by Eric Blake ( https://gitlab.com/ebblake ) had 2 failed jobs. Job #2924922479 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2924922479/raw ) Stage: builds Name: x86_64-freebsd-12 Job #2924922472 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2924922472/raw ) Stage: builds Name: x86_64-opensuse-leap-153 -- You're receiving this email because of your account on gitlab.com.

1 0

[PATCH nbdkit 0/2] file: Add fd=<FILE_DESCRIPTOR>
by Richard W.M. Jones 19 Aug '22

19 Aug '22

Patch 1 looks better if you look at it with "git show -w". This adds the ability to explicitly pass file descriptors to the file plugin, matching a recent feature of qemu. Actually this was already possible on some platforms using file=/dev/fd/<N> but it seems better to support it on all platforms[1], and make the feature and usage explicit. Rich. [1] All platforms that have inheritable, numeric file descriptors, so not Windows.

3 18

libnbd | Failed pipeline for master | 30ee21f6
by GitLab 18 Aug '22

18 Aug '22

Pipeline #617228166 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 30ee21f6 ( https://gitlab.com/nbdkit/libnbd/-/commit/30ee21f6273981bebea662f5329d1ecbe… ) Commit Message: maint: Reduce number of reverse gotos Although... Commit Author: Eric Blake ( https://gitlab.com/ebblake ) Pipeline #617228166 ( https://gitlab.com/nbdkit/libnbd/-/pipelines/617228166 ) triggered by Eric Blake ( https://gitlab.com/ebblake ) had 2 failed jobs. Job #2903841921 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2903841921/raw ) Stage: builds Name: x86_64-freebsd-12 Job #2903841914 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2903841914/raw ) Stage: builds Name: x86_64-opensuse-leap-153 -- You're receiving this email because of your account on gitlab.com.

1 0

libnbd | Failed pipeline for master | d93bfcdc
by GitLab 18 Aug '22

18 Aug '22

Pipeline #616955750 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: d93bfcdc ( https://gitlab.com/nbdkit/libnbd/-/commit/d93bfcdcdc4bfc72de69dfdd33033728a… ) Commit Message: Version 1.15.1. Commit Author: Richard W_M_ Jones ( https://gitlab.com/rwmjones ) Pipeline #616955750 ( https://gitlab.com/nbdkit/libnbd/-/pipelines/616955750 ) triggered by Richard W_M_ Jones ( https://gitlab.com/rwmjones ) had 2 failed jobs. Job #2902287412 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2902287412/raw ) Stage: builds Name: x86_64-freebsd-12 Job #2902287373 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2902287373/raw ) Stage: builds Name: x86_64-opensuse-leap-153 -- You're receiving this email because of your account on gitlab.com.

1 0

[v2v PATCH] convert_linux: start the QEMU guest agent in a distro-specific way
by Laszlo Ersek 18 Aug '22

18 Aug '22

The current command "service <package-name> start" does not apply to RHEL-6; the service name ("qemu-ga") differs from the package name ("qemu-guest-agent") there. Overhaul the logic -- detach the command from the package name; cover the RHEL, ALT, SUSE and Debian families separately. Remove the "chkconfig" command, as in all tested / investigated cases, it is unnecessary. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2028764 Signed-off-by: Laszlo Ersek <lersek(a)redhat.com> --- convert/convert_linux.ml | 56 ++++++++++++++++++++++++++++------------ 1 file changed, 40 insertions(+), 16 deletions(-) diff --git a/convert/convert_linux.ml b/convert/convert_linux.ml index 2aaa438e42ac..b8e9ad15e22d 100644 --- a/convert/convert_linux.ml +++ b/convert/convert_linux.ml @@ -66,6 +66,34 @@ let convert (g : G.guestfs) source inspect keep_serial_console _ = | _ -> None in + let qga_svc_start_cmd family distro major = + match family, distro, major with + | `RHEL_family, ( "rhel" | "centos" | "scientificlinux" | "redhat-based" | + "oraclelinux" ), 6 -> + (* https://bugzilla.redhat.com/show_bug.cgi?id=2028764#c52 *) + Some "service qemu-ga start" + + | `RHEL_family, _, _ -> + (* https://bugzilla.redhat.com/show_bug.cgi?id=2028764#c52 *) + Some "systemctl start qemu-guest-agent" + + | `ALT_family, _, _ -> + (* https://bugzilla.redhat.com/show_bug.cgi?id=2028764#c45 *) + Some "systemctl start qemu-guest-agent" + + | `SUSE_family, _, _ -> + (* https://bugzilla.redhat.com/show_bug.cgi?id=2028764#c51 *) + None + + | `Debian_family, _, _ -> + (* https://bugzilla.redhat.com/show_bug.cgi?id=2028764#c42 *) + Some "service qemu-guest-agent start" + + | _ -> + (* should never be called when "qga_pkg_of_family" returns None *) + assert false + in + assert (inspect.i_package_format = "rpm" || inspect.i_package_format = "deb"); (* Fail early if i_apps is empty. Certain steps such as kernel @@ -615,23 +643,19 @@ let convert (g : G.guestfs) source inspect keep_serial_console _ = \ \ rm -f %s\n\ fi\n" selinux_enforcing selinux_enforcing); - (* Start the agent now and at subsequent boots. The following - * commands should work on both sysvinit distros / distro versions - * (regardless of "/etc/rc.d/" vs. "/etc/init.d/" being the scheme - * in use) and systemd distros (via redirection to systemctl). - * - * On distros where the chkconfig command is redirected to - * systemctl, the chkconfig command is likely superfluous. That's - * because on systemd distros, the QGA package comes with such - * runtime dependencies / triggers that the presence of the - * virtio-serial port named "org.qemu.guest_agent.0" automatically - * starts the agent during (second and later) boots. However, even - * on such distros, the chkconfig command should do no harm. + (* On all the distro families covered by "qga_pkg_of_family" and + * "qga_svc_start_cmd", the QEMU guest agent service is always + * enabled by package installation for *subsequent* boots. Package + * installation may or may not enable the service for the current + * (i.e., first) boot, however, so try that here manually. *) - fbs "start qga" - (sprintf "#!/bin/sh\n\ - service %s start\n\ - chkconfig %s on\n" qga_pkg qga_pkg) + match qga_svc_start_cmd family inspect.i_distro inspect.i_major_version + with + | None -> () + | Some start_cmd -> + fbs "start qga" + (sprintf "#!/bin/sh\n\ + %s\n" start_cmd) with | Guest_packages.Unknown_package_manager msg | Guest_packages.Unimplemented_package_manager msg ->

2 3

libnbd | Failed pipeline for master | b31e7bac
by GitLab 18 Aug '22

18 Aug '22

Pipeline #616289691 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: b31e7bac ( https://gitlab.com/nbdkit/libnbd/-/commit/b31e7bac93c855b1e8dee41d860ba3539… ) Commit Message: states: Tolerate simple reply to structured rea... Commit Author: Eric Blake ( https://gitlab.com/ebblake ) Pipeline #616289691 ( https://gitlab.com/nbdkit/libnbd/-/pipelines/616289691 ) triggered by Eric Blake ( https://gitlab.com/ebblake ) had 2 failed jobs. Job #2898787680 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2898787680/raw ) Stage: builds Name: x86_64-freebsd-12 Job #2898787674 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2898787674/raw ) Stage: builds Name: x86_64-opensuse-leap-153 -- You're receiving this email because of your account on gitlab.com.

1 0

[libnbd PATCH 0/3] Another round of server bug toleration patches
by Eric Blake 18 Aug '22

18 Aug '22

I found some more 1-line hacks to nbdkit that can produce a subtly buggy server that is still easy enough to work around in libnbd. Eric Blake (3): states: Refactor where interrupted reply state is stored states: Skip server replies to unknown command cookies states: Tolerate simple reply to structured read request lib/internal.h | 4 +-- generator/states-reply-simple.c | 46 +++++++++++++++++++++------- generator/states-reply-structured.c | 24 ++++++++------- generator/states-reply.c | 47 ++++++++++++++--------------- 4 files changed, 73 insertions(+), 48 deletions(-) -- 2.37.1

1 4