2:28 a.m.
Why does the toplevel Makefile process appliance/, and creates
supermin.d during make install, whith configure --disable-appliance? I
have to double check what actually happens, it seems it causes startup
failures if the resulting binary packages are started on a host that
happens to have supermin installed.
Olaf
3 a.m.
On Thu, Aug 22, 2013 at 09:28:36AM +0200, Olaf Hering wrote:
Why does the toplevel Makefile process appliance/, and creates
supermin.d during make install, whith configure --disable-appliance? I
have to double check what actually happens, it seems it causes startup
failures if the resulting binary packages are started on a host that
happens to have supermin installed.
This seems to be a bug. I don't think there's anything in the
appliance/ directory which is relevant if --disable-appliance is
specified, and I guess the line:
superminfsdir = $(libdir)/guestfs/supermin.d
is processed when make install is called.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)
3:19 a.m.
On Thu, Aug 22, Richard W.M. Jones wrote:
On Thu, Aug 22, 2013 at 09:28:36AM +0200, Olaf Hering wrote:
> Why does the toplevel Makefile process appliance/, and creates
> supermin.d during make install, whith configure --disable-appliance? I
> have to double check what actually happens, it seems it causes startup
> failures if the resulting binary packages are started on a host that
> happens to have supermin installed.
What happens is that ext2_lookup fails for me. The package is build with
env \
QEMU=/usr/bin/qemu-kvm \
SUPERMIN=supermin \
SUPERMIN_HELPER=supermin-helper \
./configure --disable-appliance
So the question is: should --disable-appliance just not create the
appliance during "make", or should it also remove all supermin support
from the resulting binaries (by not creating supermin.d)?
Olaf
olaf@probook:~ $ virt-rescue -v -v -r -a
/dist/iso/13.1/openSUSE-Factory-DVD-13.1-M4-Build0651-x86_64.iso
libguestfs: launch: backend=direct
libguestfs: launch: tmpdir=/tmp/libguestfsg41wR4
libguestfs: launch: umask=0022
libguestfs: launch: euid=1000
libguestfs: command: run: supermin-helper
libguestfs: command: run: \ --verbose
libguestfs: command: run: \ -f checksum
libguestfs: command: run: \ /usr/lib64/guestfs/supermin.d
libguestfs: command: run: \ x86_64
supermin helper [00000ms] whitelist = (not specified), host_cpu = x86_64, kernel = (null),
initrd = (null), appliance = (null)
supermin helper [00000ms] inputs[0] = /usr/lib64/guestfs/supermin.d
checking modpath /lib/modules/3.9.0-rc1-probook-bko60585-00197-g9011cc2 is a directory
checking modpath /lib/modules/3.10.7-8.olh_kernel_sles11sp3.1-kernel-linux-3_10 is a
directory
checking modpath /lib/modules/3.9.0-probook-bko60585-03567-g5d434fc is a directory
checking modpath /lib/modules/3.9.11-6.olh_kernel_sles11sp3.2-kernel-linux-3_9 is a
directory
checking modpath /lib/modules/3.9.0-probook-bko60585-07168-g73287a4 is a directory
checking modpath /lib/modules/3.9.0-probook-bko60585-12587-gc4cc75c is a directory
checking modpath /lib/modules/3.9.0-probook-bko60585-01577-g507ffe4 is a directory
checking modpath /lib/modules/3.9.0-rc3-probook-bko60585-00394-g6b83f91 is a directory
checking modpath /lib/modules/3.11.0-rc2-probook-bko60585 is a directory
checking modpath /lib/modules/3.9.0-rc1-probook-bko60585-00098-g8c9e642 is a directory
checking modpath /lib/modules/3.0.80-52-desktop is a directory
checking modpath /lib/modules/3.9.11-6.olh_kernel_sles11sp3.2-kernel-linux-3_9 is a
directory
checking modpath /lib/modules/3.9.0-rc1-probook-bko60585-00049-gc37aeab is a directory
checking modpath /lib/modules/3.0.0-probook_6555b is a directory
checking modpath /lib/modules/3.10.7-8.olh_kernel_sles11sp3.1-kernel-linux-3_10 is a
directory
checking modpath /lib/modules/3.9.0-rc5-probook-bko60585-00788-ged34add is a directory
picked vmlinuz-kernel-linux-3_10
supermin helper [00096ms] finished creating kernel
supermin helper [00096ms] visiting /usr/lib64/guestfs/supermin.d
supermin helper [00096ms] visiting /usr/lib64/guestfs/supermin.d/daemon.img
supermin helper [00114ms] visiting /usr/lib64/guestfs/supermin.d/init.img
supermin helper [00130ms] visiting /usr/lib64/guestfs/supermin.d/udev-rules.img
supermin helper [00139ms] adding kernel modules
supermin helper [00448ms] finished creating appliance
libguestfs: checksum of existing appliance:
057acdefb7acae7dfdc60855c4ce1cb07c021141809f45a101c59ed6e5bb8612
libguestfs: [00566ms] begin building supermin appliance
libguestfs: [00578ms] run supermin-helper
libguestfs: command: run: supermin-helper
libguestfs: command: run: \ --verbose
libguestfs: command: run: \ --copy-kernel
libguestfs: command: run: \ -f ext2
libguestfs: command: run: \ /usr/lib64/guestfs/supermin.d
libguestfs: command: run: \ x86_64
libguestfs: command: run: \ /tmp/guestfs.dsGfar/kernel
libguestfs: command: run: \ /tmp/guestfs.dsGfar/initrd
libguestfs: command: run: \ /tmp/guestfs.dsGfar/root
supermin helper [00000ms] whitelist = (not specified), host_cpu = x86_64, kernel =
/tmp/guestfs.dsGfar/kernel, initrd = /tmp/guestfs.dsGfar/initrd, appliance =
/tmp/guestfs.dsGfar/root
supermin helper [00000ms] inputs[0] = /usr/lib64/guestfs/supermin.d
checking modpath /lib/modules/3.9.0-rc1-probook-bko60585-00197-g9011cc2 is a directory
checking modpath /lib/modules/3.10.7-8.olh_kernel_sles11sp3.1-kernel-linux-3_10 is a
directory
checking modpath /lib/modules/3.9.0-probook-bko60585-03567-g5d434fc is a directory
checking modpath /lib/modules/3.9.11-6.olh_kernel_sles11sp3.2-kernel-linux-3_9 is a
directory
checking modpath /lib/modules/3.9.0-probook-bko60585-07168-g73287a4 is a directory
checking modpath /lib/modules/3.9.0-probook-bko60585-12587-gc4cc75c is a directory
checking modpath /lib/modules/3.9.0-probook-bko60585-01577-g507ffe4 is a directory
checking modpath /lib/modules/3.9.0-rc3-probook-bko60585-00394-g6b83f91 is a directory
checking modpath /lib/modules/3.11.0-rc2-probook-bko60585 is a directory
checking modpath /lib/modules/3.9.0-rc1-probook-bko60585-00098-g8c9e642 is a directory
checking modpath /lib/modules/3.0.80-52-desktop is a directory
checking modpath /lib/modules/3.9.11-6.olh_kernel_sles11sp3.2-kernel-linux-3_9 is a
directory
checking modpath /lib/modules/3.9.0-rc1-probook-bko60585-00049-gc37aeab is a directory
checking modpath /lib/modules/3.0.0-probook_6555b is a directory
checking modpath /lib/modules/3.10.7-8.olh_kernel_sles11sp3.1-kernel-linux-3_10 is a
directory
checking modpath /lib/modules/3.9.0-rc5-probook-bko60585-00788-ged34add is a directory
picked vmlinuz-kernel-linux-3_10
supermin helper [00150ms] finished creating kernel
supermin helper [06631ms] finished mke2fs
supermin helper [06632ms] visiting /usr/lib64/guestfs/supermin.d
supermin helper [06632ms] visiting /usr/lib64/guestfs/supermin.d/daemon.img
supermin helper [06711ms] visiting /usr/lib64/guestfs/supermin.d/init.img
supermin helper [06711ms] visiting /usr/lib64/guestfs/supermin.d/udev-rules.img
supermin-helper: ext2: parent directory not found: /lib: File not found by ext2_lookup
libguestfs: error: supermin-helper exited with error status 1, see debug messages above
libguestfs: command: run: rm
libguestfs: command: run: \ -rf /tmp/guestfs.dsGfar
libguestfs: closing guestfs handle 0x654f10 (state 0)
libguestfs: command: run: rm
libguestfs: command: run: \ -rf /tmp/libguestfsg41wR4
olaf@probook:~ $
3:47 a.m.
On Thu, Aug 22, 2013 at 10:19:18AM +0200, Olaf Hering wrote:
On Thu, Aug 22, Richard W.M. Jones wrote:
> On Thu, Aug 22, 2013 at 09:28:36AM +0200, Olaf Hering wrote:
> > Why does the toplevel Makefile process appliance/, and creates
> > supermin.d during make install, whith configure --disable-appliance? I
> > have to double check what actually happens, it seems it causes startup
> > failures if the resulting binary packages are started on a host that
> > happens to have supermin installed.
What happens is that ext2_lookup fails for me. The package is build with
env \
QEMU=/usr/bin/qemu-kvm \
SUPERMIN=supermin \
SUPERMIN_HELPER=supermin-helper \
./configure --disable-appliance
So the question is: should --disable-appliance just not create the
appliance during "make", or should it also remove all supermin support
from the resulting binaries (by not creating supermin.d)?
[...]
supermin helper [06632ms] visiting /usr/lib64/guestfs/supermin.d
supermin helper [06632ms] visiting /usr/lib64/guestfs/supermin.d/daemon.img
supermin helper [06711ms] visiting /usr/lib64/guestfs/supermin.d/init.img
supermin helper [06711ms] visiting /usr/lib64/guestfs/supermin.d/udev-rules.img
supermin-helper: ext2: parent directory not found: /lib: File not found by ext2_lookup
It looks as if base.img and hostfiles are not being created, but the
daemon.img (guestfsd), init.img (/init) and udev-rules.img files are
still being created, so essentially making a broken supermin image.
./configure --disable-appliance should probably skip the appliance
subdirectory (of the source) entirely, and it seems like it would fix
this problem.
Also of note:
Even if you use --disable-appliance, libguestfs is built with code to
handle supermin appliances (see src/appliance.c). If you don't want
to use supermin images at all (and no SuSE users wants to), it may be
a good idea to have a separate ./configure flag which disables this
code. OTOH this code won't do anything harmful by just being included.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW
4091
days inactive
4091
days old
3 comments
2 participants
participants (2)
-
Olaf Hering -
Richard W.M. Jones