Re: [Libguestfs] [PATCH 2/3] inspection: Add support for CoreOS
On Tue, Jun 02, 2015 at 06:37:06PM +0300, Nikos Skalkotos wrote:
Sorry, I don't get it. In inspect.c line 67 you have this:
for (fs = fses; *fs; fs += 2) {
if (guestfs_int_check_for_filesystem_on (g, *fs)) {
guestfs_int_free_inspect_info (g);
return NULL;
}
}
Oh I see, yes that's a bug too.
I don't see the bug.
I was looking at this other bug in src/inspect-fs.c:
static int
extend_fses (guestfs_h *g)
{
size_t n = g->nr_fses + 1;
struct inspect_fs *p;
p = realloc (g->fses, n * sizeof (struct inspect_fs));
if (p == NULL) {
perrorf (g, "realloc");
return -1;
}
Should probably just call safe_realloc ..
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html