Re: [Libguestfs] [p2v PATCH 08/10] nbd.c: remove "enum nbd_server"
On 03/31/22 15:03, Richard W.M. Jones wrote:
For patches 4-8:
Reviewed-by: Richard W.M. Jones <rjones(a)redhat.com>
I would be tempted to squash a few of these together before pushing,
but whatever you wish.
I'd like to keep them separate; I made a big effort to proceed with
these changes as gradually as possible. My first try was to rip it all
out in one go, it very quickly became intractable, and once I implement
the simplifications gradually, I would like to commit them that way too.
In particular, patch#5 ("nbd.c: remove bind_source_port()") undoes a fix
for a very obscure bug (RHBZ#1167774) because the changed conditions no
longer make that bug possible. I spent a very long time composing the
commit message there (= the argument for rolling back the bugfix); I
really want that to stand alone.
Thanks!
Laszlo