Re: [Libguestfs] [PATCH 03/27] daemon: Reimplement ‘file’ API in OCaml.
On Wed, Jul 19, 2017 at 03:14:48PM +0200, Pino Toscano wrote:
> +
> + let statbuf = Chroot.f chroot lstat path in
Hm is chroot needed for this? The current C implementation does not
use CHROOT_IN/OUT, and it does not even resolve symlinks, so it should
be safe.
The implementation is different, but I think it's equivalent and safe.
The ‘Chroot’ module is a significant enhancement over the C CHROOT_*
hacks and over the cases where the C code should be doing a chroot but
doesn't even bother.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines. Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v