Re: [Libguestfs] [libnbd PATCH v4 0/2] lib/utils: introduce async-signal-safe execvpe()

On Tue, Mar 21, 2023 at 07:04:59AM +0100, Laszlo Ersek wrote: ... I see you already fixed one pipeline failure due to some gcc versions being more picky about function __attribute__ placement than others. The remaining failures are with alpine Linux, where /bin/expr comes from busybox instead of coreutils, and has the unfortunate quality of having its behavior dependent on argv[0]. Starting from a clean clone, I reproduced it locally with: $ git diff diff --git i/lib/test-fork-safe-execvpe.sh w/lib/test-fork-safe-execvpe.sh index 838bac9..4b3700c 100755 --- i/lib/test-fork-safe-execvpe.sh +++ w/lib/test-fork-safe-execvpe.sh @@ -18,7 +18,7 @@ . ../tests/functions.sh -set -e +set -ex # Determine the absolute pathname of the execvpe helper binary. The "realpath" # utility is not in POSIX, but Linux, FreeBSD and OpenBSD all have it. @@ -155,7 +155,7 @@ success() # Create a temporary directory and change the working directory to it. tmpd=$(mktemp -d) -cleanup_fn rm -r -- "$tmpd" +#cleanup_fn rm -r -- "$tmpd" cd "$tmpd" # If the "file" parameter of execvpe() is an empty string, then we must fail -- $ podman build -f ci/containers/alpine-edge.Dockerfile -t libnbd-alpine-edge $ podman run -it --rm --userns=keep-id -v .:/repo:z -w /repo libnbd-alpine-edge bash $ ./configure $ make check $ grep tmpd= lib/test-suite.log + tmpd=/tmp/tmp.EMgKeF $ /tmp/tmp.EMgKeF/bin/f 1 + 1 f: applet not found 0b748c9fe495:~$ So it looks like we need some way to work around busybox' insistance that argv[0] determines which applet to run. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org