[Libguestfs] [PATCH VERSION 6] Generic partition creation interface.
I think this patch is looking in good shape to be reviewed and applied
now.
On Mon, Nov 09, 2009 at 10:08:32AM +0100, Jim Meyering wrote:
Richard W.M. Jones wrote:
...
> (3) Work around an apparent bug in parted where it fails to do
> ioctl(BLKRRPART) [re-read the partition table], by catching this case
> and rereading the partition table ourselves.
Hi Rich,
I haven't looked at that patch yet, but this part rings big bells:
parted-2.0+ (not yet in rawhide) has had significant changes in this area.
The workaround should be safe, in that it looks for the specific error
string that parted 1.9 throws and tries to reread the partition table.
Rereading the partition table is always safe, even if we do it at the
wrong time.
> ** NOT TO BE PUSHED ** This doesn't quite work at the
moment. All the
> tests pass, except: test_list_partitions_0 wipes the disk and creates
> a single partition covering the whole disk. However the test fails
> because it thinks the disk has 3 partitions. At the moment I have no
> idea why it would think this.
If this is still a problem, let me know and I'll take a look.
This fixed itself. That's the sort of bug I like.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
New in Fedora 11: Fedora Windows cross-compiler. Compile Windows
programs, test, and build Windows installers. Over 70 libraries supprt'd
http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw
Attachments:
- 0001-Generic-partition-creation-interface.patch (text/plain — 34.9 KB)