On Mon, Jun 15, 2015 at 04:06:09PM +0200, Pino Toscano wrote:
On Sunday 14 June 2015 14:37:26 Richard W.M. Jones wrote:
--- a/generator/actions.ml +++ b/generator/actions.ml @@ -615,7 +615,7 @@ against. Note that because of dynamic linking this is not necessarily the version of libguestfs that you compiled against. You can compile the program, and then at runtime dynamically link -against a completely different C<libguestfs.so> library. +against a completely different F<libguestfs.so> library.
This call was added in version C<1.0.58>. In previous versions of libguestfs there was no way to get the version @@ -830,7 +830,7 @@ to specify the QEMU interface emulation to use at run time." }; ]; shortdesc = "detect the architecture of a binary file"; longdesc = "\ -This detects the architecture of the binary C<filename>, +This detects the architecture of the binary F<filename>, and returns it if known.
(and other similar cases here in actions.ml)
Considering that "filename" is the name of parameter, shouldn't it be better left with C<>?
It's a bit of a tricky corner case, but at least I changed all filename parameters to F<...> (fairly) consistently :-)
@@ -81,9 +81,9 @@ C<VIRT_P2V_DATA_DIR> environment variable.
=item C<$datadir/issue>
-=item C<$datadir/launch-virt-p2v.in> +=item F<$datadir/launch-virt-p2v.in>
-=item C<$datadir/p2v.service> +=item F<$datadir/p2v.service>
I guess C<$datadir/issue> too?
Yup - fixed, thanks. There was another one in virt-p2v-make-kickstart which I also fixed. Rich.
The rest seems fine to me.
Thanks, -- Pino Toscano
_______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html