Re: [Libguestfs] [PATCH v2 2/2] v2v: -i vmx: Enhance VMX support with ability to use ‘-it ssh’ transport.
On Fri, Dec 08, 2017 at 06:04:51PM +0100, Pino Toscano wrote:
IMHO this new transport could use the standard URI syntax, so
root(a)esxi.example.com/vmfs/volumes/datastore1/guest/guest.vmx
instead of
root@esxi.example.com:/vmfs/volumes/datastore1/guest/guest.vmx
This way, Xml.parse_uri can be used to parse it, giving a better code
for extracting all the parts (including the port, for example).
I tried this, see attached incremental patch, but it has a few
problems:
(1) You must use ssh://... else XmlParseURI cannot parse the URI.
(2) You must replace all spaces with %20 in the path. This is a bit
of a pain since VMware VM names frequently contain spaces, and the
path will contains x 2 the number of spaces.
On the flip side, adding support for port numbers was possible.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW
Attachments:
- 0001-V2V-USE-URI-FOR-REMOTE-VMX-PATH.patch (text/plain — 9.1 KB)