Re: [Libguestfs] [PATCH 2/2] v2v: -i ova: Factor out the OVF parsing into a separate module.
In data lunedì 13 marzo 2017 13:14:52 CET, Richard W.M. Jones ha scritto:
Mixing the XML parsing with the other functions of this module made
it
very hard to understand. Splitting the XML parsing into another
module simplifies the flow considerably.
This is just code refactoring and should not affect the semantics.
---
Mostly LGTM, just one note:
+ "driver", JSON.String
"raw";
+ "offset", JSON.Int64 offset;
+ "size", JSON.Int64 size;
+ "file", JSON.Dict [
+ "driver", JSON.String
"file";
+ "filename", JSON.String ova]
+ ]
+ ] in
The indentation of this block seems weird.
Thanks,
--
Pino Toscano