Re: [Libguestfs] [libnbd PATCH v5 3/5] force semicolon after DEFINE_VECTOR_TYPE() macro invocations
On 2/27/23 15:04, Eric Blake wrote:
On Sun, Feb 26, 2023 at 12:45:27PM +0100, Laszlo Ersek wrote:
> Currently, a semicolon after a DEFINE_VECTOR_TYPE(...) macro invocation is
> not needed, nor does our documentation in "common/utils/vector.h"
> prescribe one. Furthermore, it breaks ISO C, which gcc reports with
> "-Wpedantic":
>
>> warning: ISO C does not allow extra ‘;’ outside of a function
>> [-Wpedantic]
>
> Our current usage is inconsistent; a proper subset of all our
> DEFINE_VECTOR_TYPE() invocations is succeeded by a semicolon. We could
> remove these semicolons, but that doesn't play nicely with Emacs's C
I'm not sure if the possessive is spelled "Emacs'".
Right, I had gotten interested in that question a while ago.
https://en.wikipedia.org/wiki/English_possessive
https://en.wikipedia.org/wiki/Apostrophe#Possessive_apostrophe
I guess one part of the equation is whether we now consider "Emacs" an
"ossified" acronym, i.e., a simple proper noun, or if we still "feel"
the plural embedded in it ("Editor MACroS"). In the former case, the
forms quoted by the first article as valid ("Mitch's",
"James's",
"Charles's") seem to apply. If we consider "Emacs" to be the
plural form
of "Emac" (an editor macro), then it should be "Emacs'", i.e.
"Editor
Macros' C language parser".
Personally, I consider "Emacs" the word a proper noun; even for the
above, I had to look up its etimology.
Either way,
Reviewed-by: Eric Blake <eblake(a)redhat.com>
Thanks, and...
> language parser. Thus, force the semicolon instead.
>
> Signed-off-by: Laszlo Ersek <lersek(a)redhat.com>
> ---
>
> Notes:
> v5:
> - force semicolon after DEFINE_VECTOR_TYPE() [Eric]
> - reword commit message accordingly
>
> v4:
> - new patch in v4
>
> common/utils/vector.h | 7 +++++--
> lib/uri.c | 2 +-
> copy/file-ops.c | 2 +-
> copy/nbd-ops.c | 2 +-
> dump/dump.c | 2 +-
> fuse/nbdfuse.h | 2 +-
> info/list.c | 2 +-
> info/map.c | 2 +-
> ublk/nbdublk.h | 2 +-
> ublk/tgt.c | 2 +-
> 10 files changed, 14 insertions(+), 11 deletions(-)
I grepped to make sure no other files had the pattern, even if they
weren't being compiled by your choice of configure options.
Thanks! Yes, I did grep too.
Laszlo