Re: [Libguestfs] [PATCH nbdkit 1/9] server: Add libnbdkit.so.
On 8/18/20 8:53 AM, Richard W.M. Jones wrote:
On Tue, Aug 18, 2020 at 07:48:43AM -0500, Eric Blake wrote:
>> +extern int nbdkit_main (int argc, char *argv[]);
>
> A bit odd to declare this in a .c; but I don't see any existing
> decent .h to put it in, nor is it worth adding a new one just for
> this. So it is fine right here.
Yup, better suggestions greatfully accepted, but I couldn't see
anywhere obvious. Maybe internal.h?
That would work for me.
> Do we want to export it as _nbdkit_main, to make it obvious that
> plugins shouldn't try calling it? That's cosmetic if you think it
> is worth it.
I was a bit in two minds about whether this API should be public or
not. Could it be called by other programs? Would it be useful for
other programs? Would that just cause us trouble in future?
I'm having a hard time seeing why any other program would want to call
it; we assume enough control over our environment that being a library
in the context of a larger multi-threaded app will probably violate
those assumptions.
I don't intend to push any of this stuff until the 1.23 development
branch opens.
Fair enough. Then I'd better finish up my work on .list_exports,
.default_export, and .export_description to get those done before 1.22.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org