Re: [Libguestfs] [PATCH nbdkit] s3: Only run the tests if boto3 is installed
On May 17 2022, Laszlo Ersek <lersek(a)redhat.com> wrote:
I think so, yes: from your description, "test-S3-unit.sh"
seems "less
demanding" than "test-S3.sh", so if the mocked module satisfies the
latter, it should be good enough for the former too.
Not quite. test-S3-unit.sh exercises the write path and the
multiple-object support (but without nbdkit). test-S3.sh tests reading
one single object (through nbdkit).
I think ideally both tests should be done once in pure Python and once
through nbdkit. I didn't do it that way because at first I didn't see
any existing test coverage at all, and thus started from scratch.
Best,
-Nikolaus
--
GPG Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F
»Time flies like an arrow, fruit flies like a Banana.«