Re: [Libguestfs] [PATCH libnbd 0/2] Change qemu-nbd interop tests to use socket activation.
On 10/1/19 11:15 AM, Richard W.M. Jones wrote:
Now that we have implemented systemd socket activation, we can use
this to run qemu-nbd in tests.
The first patch leaves some dead code around (the -DSERVE_OVER_TCP=1
path). It's possible we might want to use this to test against a
putative future NBD server that only supports TCP, but on the other
hand maybe we should just remove it.
Tests & valgrind still pass for me.
Cool - by passing in a socket, we can bypass qemu-nbd's insistence on
TCP (still on my TODO list to get qemu-nbd to support TLS over Unix
sockets, but socket activation does bypass that limitation), and avoid
having to wait for the server to give us some indication that the socket
is up (because it is already up). I like it!
ACK series
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org