Re: [Libguestfs] [PATCH nbdkit 3/4] tests: Move common code for testing every plugin to tests/functions.sh.
On Tue, Sep 11, 2018 at 02:21:27PM -0500, Eric Blake wrote:
>+++ b/tests/test-dump-plugin.sh
>@@ -31,9 +31,9 @@
> # OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
> # SUCH DAMAGE.
>+source functions.sh
> set -e
> set -x
>-source ./functions.sh
You NEED to use ./ with source (otherwise, you perform a PATH
search, which fails if ./ is not in PATH); this change is a
regression.
(Whether you use the shorter '.' instead of the longer bashism
'source' is up to you, since the tests all use bash)
Fair enough. I didn't realize that source would use a path search,
since I guess it can't use exec*p internally. But I checked the man
page and you are quite right -- it's using $PATH. I will change all
these back to "./functions.sh".
Thanks,
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW