Re: [Libguestfs] [PATCH v3 4/6] lib: qemu: Allow parallel qemu binaries to be used with cache conflicts.
On Tuesday, 12 September 2017 19:04:22 CEST Richard W.M. Jones wrote:
Rename the cache files like ‘qemu.stat’ etc so they include the qemu
binary "key" (ie. size and mtime) in the name. This allows a single
user to use multiple qemu binaries in parallel without conflicts.
---
My concern here is that these files will pile up in the caches of the
various users -- especially the newly added qmp-schema cache is
(generated on my Fedora 26) a 90+ KB output. Every time qemu changes
there will at least 125/130+ KB used (10+ KB for devices, 25+ KB for
help, 90+ KB for qmp-schema), and those are never cleaned up
automatically.
-/* This is saved in the qemu.stat file, so if we decide to change
the
+/* This is saved in the qemu-*.stat file, so if we decide to change the
* test_qemu memoization format/data in future, we should increment
* this to discard any memoized data cached by previous versions of
* libguestfs.
*/
-#define MEMO_GENERATION 2
+#define MEMO_GENERATION 3
Maybe just a nitpick: since this commit just changes the location of the
cached files, but keeps the format unchanged, then I guess bumping
MEMO_GENERATION is not strictly needed.
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)