[Libguestfs] [PATCH] Fix broken qemu <= 0.10 which randomly adds a CD-ROM device to the appliance

qemu <= 0.10 randomly adds a CD-ROM device to the appliance because of this bit of code: http://git.savannah.gnu.org/cgit/qemu.git/tree/vl.c?h=stable-0.10#n5495 Thankfully this code has been removed from upstream qemu. Anyway I'm not quite sure why we never saw this before - it seems like this code didn't exist in the versions of qemu that were in Fedora, or somehow this code only runs some of the time. But anyway, this breaks the tests in Fedora 11 and RHEL 5.3 right now. The attached code attempts to work around this stupidity by adding checks in list_devices and list_partitions to see if the device is openable, and ignoring any which aren't. These fake, empty CD drives fail this extra check with error "No medium found", so they get ignored. [I'm still running all the tests with this patch, so not quite sure if it's correct.] Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v